Update Company::update method to support providing an id.#349
Open
MinDBreaK wants to merge 2 commits intointercom:masterfrom
Open
Update Company::update method to support providing an id.#349MinDBreaK wants to merge 2 commits intointercom:masterfrom
MinDBreaK wants to merge 2 commits intointercom:masterfrom
Conversation
Allow update method to update a specified company with an id.
The function is a Symfony only function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow update method to update a specified company with an id.
Why?
The API supports the update via ID but not the SDK. There is a workaround but it is not clean to use directly the client.
How?
I added the ID in the arguments of the update method and added a BC layer to avoid breaking apps or having to bump a major version.
On next major version, the BC layer will need to be removed.